Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Oct 31, 2025

DESCRIBE YOUR PR

Remove instructions for enabling metrics since the requirements were removed from the SDK: getsentry/sentry-python#5046

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): November 15
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Nov 11, 2025 10:13am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Nov 11, 2025 10:13am

@alexander-alderman-webb alexander-alderman-webb requested a review from a team October 31, 2025 12:08
@codecov
Copy link

codecov bot commented Oct 31, 2025

Bundle Report

Changes will increase total bundle size by 1.76kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.84MB 1.77kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 593 bytes 845.98kB 0.07%
../app/platform-redirect/page.js.nft.json 593 bytes 845.9kB 0.07%
../app/sitemap.xml/route.js.nft.json 593 bytes 843.13kB 0.07%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/SOwI-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/SOwI-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/ze7P0Tr-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/ze7P0Tr-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review November 10, 2025 16:05
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexander-alderman-webb alexander-alderman-webb changed the title feat(python): Metrics in open beta feat(python): non-experimental metrics options Nov 11, 2025
@alexander-alderman-webb alexander-alderman-webb merged commit 1b09291 into master Nov 11, 2025
14 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/metrics-open-beta branch November 11, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants