-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(mdx): Handle read-only filesystems during MDX compilation #15453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3476ecd
fix(mdx): Handle read-only filesystems during MDX compilation
seer-by-sentry[bot] c7de3b5
Merge branch 'master' into seer/fix-mdx-readonly-fs
KyleTryon b333f06
Update src/mdx.ts
KyleTryon 0eebbd4
Update src/mdx.ts
KyleTryon 56a7f52
fix: lint - unused import
KyleTryon 25d98f4
[getsentry/action-github-commit] Auto commit
getsantry[bot] f947ead
Merge branch 'master' into seer/fix-mdx-readonly-fs
KyleTryon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dynamic Assets Unwritten in Runtime
Setting
options.write = falsein non-CI environments prevents esbuild from writing output files, but there's no code to manually writeresult.outputFileswhenwriteis false. In Lambda/runtime environments,assetsCacheDiris null, so the copy operation at line 721 doesn't execute, leaving generated assets (images, etc.) unwritten. This breaks dynamic content that wasn't pre-built.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cursoragent can you break down what is being written, where it was being written, and what its purpose was. Was this recently changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to increase your spend limit or enable usage-based billing to run background agents. Go to Cursor