Skip to content

Conversation

@runningcode
Copy link
Contributor

@runningcode runningcode commented Nov 13, 2025

Summary

  • Updates size analysis docs to use dynamic version injection for sentry-cli
  • Adds note specifying minimum required version of 2.58.2
  • Changes Note component to Alert component in include files
  • Removes duplicate fastlane plugin version reference

Fixes EME-382

🤖 Generated with Claude Code

@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Nov 13, 2025 9:30am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Nov 13, 2025 9:30am

@linear
Copy link

linear bot commented Nov 13, 2025

@runningcode runningcode requested a review from chromy November 13, 2025 08:50
@codecov
Copy link

codecov bot commented Nov 13, 2025

Bundle Report

Changes will increase total bundle size by 2.75kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.17MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.62MB 2.76kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 922 bytes 770.51kB 0.12%
../app/platform-redirect/page.js.nft.json 922 bytes 770.42kB 0.12%
../app/sitemap.xml/route.js.nft.json 922 bytes 767.65kB 0.12%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/Och6ewOC3Zj2Glx0fR7kv/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/Och6ewOC3Zj2Glx0fR7kv/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/ty6ub2lerJFxNqwFNjCnU/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/ty6ub2lerJFxNqwFNjCnU/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Update size analysis documentation to use dynamic version injection for
sentry-cli and specify minimum required version of 2.58.2.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@runningcode runningcode force-pushed the no/update-size-analysis-cli-version branch from 360490a to 1b1033e Compare November 13, 2025 09:07
@codeowner-assignment codeowner-assignment bot requested a review from a team November 13, 2025 09:07
Copy link
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks!

**Accepted Formats**: XCArchive (preferred) | IPA

**Upload Mechanisms**: [Fastlane Plugin](#uploading-with-fastlane) (version 1.34.0 or higher) _or_ [Sentry CLI](#uploading-with-the-sentry-cli)
**Upload Mechanisms**: [Fastlane Plugin](#uploading-with-fastlane) _or_ [Sentry CLI](#uploading-with-the-sentry-cli)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Why did you remove the minimum version of the fastlane plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, its redundant since we also mention the number in the size-analysis/upload-fastlane included below.

Image

@runningcode runningcode merged commit 39db641 into master Nov 13, 2025
14 checks passed
@runningcode runningcode deleted the no/update-size-analysis-cli-version branch November 13, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants