ref(develop/scopes): Clarify unit type for attributes #15546
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
cleptric
approved these changes
Nov 18, 2025
Lms24
commented
Nov 18, 2025
codyde
added a commit
that referenced
this pull request
Nov 19, 2025
….com/getsentry/sentry-docs into feat/python-docs-nav-standardization * 'feat/python-docs-nav-standardization' of https://github.com/getsentry/sentry-docs: ref: Allign badges with Sentry’s in-product ones (#15561) feat: Document exporting from OTLP from shopify hydrogen storefronts (#15534) docs(size-analysis): Update sentry-android-gradle-plugin to 6.0.0-beta.2 (#15560) fix(developer docs): Correcting width issues in developer docs for toc (#15559) docs(feature-flag): add documentation for php feature flags (#15443) feat(python): Illustrate types of metrics (#15556) fix(dev-docs): Buffer fixes for logs and metrics (#15513) docs(sourcemaps): Remove mentions of `sentry-cli sourcemaps explain` (#15481) ref(develop/scopes): Clarify unit type for attributes (#15546) ref(develop/spans): Clarify span attribute `unit` and `type` types (#15547) docs(metrics): add upcoming SDKs to Metrics getting started page (#15545) doc(proguard): No inbound filters (#15543) getsentry/relay@9b19609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we specify units on attributes as follows:
MetricUnits (see Relay)'','none'We recognize that attribute units are therefore typed more strictly than e.g. units for metrics (they currently also accept custom units) but we can adjust both in either direction in the future.