-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Monitors alerts LA version #15550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…h directory changes.
Resolved conflicts: - docs/product/alerts/index.mdx: Kept new alert description and sidebar_order, added og_image from master - docs/security-legal-pii/security/data-retention-periods.mdx: Merged retention period updates from master with documentation links - Removed 6 old alert documentation files that were restructured (alert-types.mdx, create-alerts/*)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
| }, | ||
| "status": "in_progress" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: JSON Syntax Errors Break Monitor Example
Invalid JSON syntax in the monitor upsert example. Line 118 is missing a comma after "timezone": "America/Los_Angeles", and line 120 has a trailing comma after "recovery_threshold": 1, which is invalid JSON. These errors will prevent the example from working when copied and used.
|
|
||
| <Expandable title="Why aren't recurring job errors showing up on my monitor details page?"> | ||
|
|
||
| You may not have [linked errors to your monitor](/product/new-monitors-and-alerts/monitors/crons/getting-started/http/#connecting-errors-to-cron-monitors). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Troubleshooting Link Leads Nowhere
Broken link reference. The troubleshooting page links to #connecting-errors-to-cron-monitors anchor in the HTTP getting started guide, but this section doesn't exist in that file. This will result in a broken anchor link that users won't be able to navigate to.
Bundle ReportChanges will increase total bundle size by 75.41kB (0.32%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
updated links according to getsentry/sentry-docs#15550 we'll be keeping monitors/alerts docs in a separate folder during LA so that they're still published/accessible but don't interfere with the structure of existing docs
DESCRIBE YOUR PR
Created an LA directory for "new monitors and alerts"
Preview:
https://sentry-docs-git-monitors-alerts-la-version.sentry.dev/product/new-monitors-and-alerts/
https://sentry-docs-git-monitors-alerts-la-version.sentry.dev/product/new-monitors-and-alerts/alerts/
https://sentry-docs-git-monitors-alerts-la-version.sentry.dev/product/new-monitors-and-alerts/monitors/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: