-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(nextjs): Move webpack build config under webpack namespace
#15691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 1.77kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
inventarSarah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍looks good to me
docs/platforms/javascript/guides/nextjs/configuration/build/index.mdx
Outdated
Show resolved
Hide resolved
| have no effect. The Sentry SDK will no longer apply build-time instrumentation | ||
| and will rely purely on Next.js telemetry features. | ||
| </Alert> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove the alert about Turbopack in the lines above. wdyt?
This one:
<Alert level="info">
If you're building your Next.js application with Turbopack, this option will
have no effect. The Sentry SDK will no longer apply build-time instrumentation
and will rely purely on Next.js telemetry features.
</Alert>
…dex.mdx Co-authored-by: Sarah Mischinger <sarah@codingwriter.com>
We are moving the only-webpack related configurations under
webpacknamespace to better fit our goal of communicating the SDK readiness for Turbopack by default.This involved moving several options to be nested under a
webpackpath in the build configuration.This is meant to be released once this getsentry/sentry-javascript#18343 goes live, so I will keep this open until then. Will keep it in draft as well.
The SDK PR adds warnings for those deprecated options and warns users about using them if detected so I don't think we need to do that here once it goes live.