Skip to content

Conversation

@PeloWriter
Copy link
Contributor

@PeloWriter PeloWriter commented Mar 4, 2021

This PR moves the Flutter docs content into the common format and fixes some common content issues that surfaced during the fixing.

To do (@marandaneto will work with me on this):

  • determine if we need a migration guide
  • review the options list on Configurations > Basic Options and add to the content as needed
  • add a code sample to configuration/decluttering on the Filtering page
  • Clarify if the scopes content should display and add the missing code sample
  • refine the Feature list

@PeloWriter PeloWriter requested a review from a team as a code owner March 4, 2021 00:25
@vercel
Copy link

vercel bot commented Mar 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/2ma2iY2YvuvUiqdt6BRHgw9Zwjrz
✅ Preview: https://sentry-docs-git-update-flutter-docs-improvements.sentry.dev


Features:

- Automatic native crash error tracking (using both [Android](/platforms/android/) and [iOS](/platforms/apple/)), including
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also Support Flutter Web, it's a bit limited compared to Android and iOS, of course.
Eg, events are not enriched with device context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added "Limited Support for Flutter Web" - LMK if there's a link to add or if that wording is quite what we want here @bruno-garcia

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me, so we don't create much expectations from Web devs as we didn't spend time on it

@marandaneto
Copy link
Contributor

determine if we need a migration guide

ideally yes, migrating the Dart v3 to Dart v4 or Flutter v4, but we should not block this PR by that

@marandaneto
Copy link
Contributor

add a code sample to configuration/decluttering on the Filtering page

we don't have any logging integration, for now, hence this is not needed

@marandaneto
Copy link
Contributor

Clarify if the scopes content should display and add the missing code sample

it's good to go, we don't support Local scopes

@marandaneto
Copy link
Contributor

configurations:

supported and missing:

auto-session-tracking
integrations
transport

I've noticed that these 3 are supported across the Mobile SDKs.
For the other platforms, we can work on it here #2985

@marandaneto
Copy link
Contributor

@PeloWriter I left a few comments, looks great, thanks for doing that, wondering if we could expand these changes later on on the Dart SDK as well, pretty much the same structure, way nicer, thanks once more.

@marandaneto
Copy link
Contributor

should we take a look at the wizard too? see if something is off after these changes or if something could be improved?

@PeloWriter PeloWriter mentioned this pull request Mar 4, 2021
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit a67b5a6 into master Mar 5, 2021
@marandaneto marandaneto deleted the update/flutter-docs-improvements branch March 5, 2021 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants