Skip to content

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jun 27, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Closes #3611

I've not found a common doc to place this, so added it only to Mobile data privacy for Mobile right now, ideas where I can place this that is common content for all SDKs?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 7:52am

@marandaneto marandaneto requested a review from a team June 27, 2023 09:42
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
@marandaneto marandaneto requested a review from lizokm June 27, 2023 09:48
marandaneto and others added 2 commits June 27, 2023 11:53
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
Co-authored-by: Stefan Jandl <reg@bitfox.at>
@shanamatthews
Copy link
Contributor

I've not found a common doc to place this, so added it only to Mobile data privacy for Mobile right now, ideas where I can place this that is common content for all SDKs?

Chatted with @vivianyentran about this - I don't think this is the best spot for these docs.

Could we put general info about using Sentry in SDKs on the platforms index page? src/platforms/index.mdx
If there's SDK-specific info, we could put that in a note on SDK getting started pages.

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
@marandaneto
Copy link
Contributor Author

I've not found a common doc to place this, so added it only to Mobile data privacy for Mobile right now, ideas where I can place this that is common content for all SDKs?

Chatted with @vivianyentran about this - I don't think this is the best spot for these docs.

Could we put general info about using Sentry in SDKs on the platforms index page? src/platforms/index.mdx If there's SDK-specific info, we could put that in a note on SDK getting started pages.

Sounds good, added it here as suggested c3c8c43

@marandaneto
Copy link
Contributor Author

Screenshot 2023-06-28 at 09 55 54

@vivianyentran @shanamatthews let me know what you think, feel free to hit the merge button if all is good :) thanks for the feedback.

@bruno-garcia bruno-garcia requested a review from billyvg June 28, 2023 14:59
@bruno-garcia
Copy link
Member

tagged @billyvg from the replay pov

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor improvements suggestions but lgtm

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@marandaneto marandaneto enabled auto-merge (squash) June 29, 2023 07:37
@marandaneto marandaneto merged commit 112ea0f into master Jun 29, 2023
@marandaneto marandaneto deleted the chore/sdks-thirdparty-sdks branch June 29, 2023 07:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document if Mobile SDKs are supported for library authors

8 participants