Skip to content

Clarify intent of PreFlightIgnoresTransaction test #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify intent of PreFlightIgnoresTransaction test #4792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions ....AspNetCore.Tests/WebIntegrationTests.PreFlightIgnoresTransaction.DotNet10_0.verified.txt
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions ...y.AspNetCore.Tests/WebIntegrationTests.PreFlightIgnoresTransaction.DotNet8_0.verified.txt
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions ...y.AspNetCore.Tests/WebIntegrationTests.PreFlightIgnoresTransaction.DotNet9_0.verified.txt
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions test/Sentry.AspNetCore.Tests/WebIntegrationTests.verify.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,9 @@ public async Task PreFlightIgnoresTransaction()
// dispose will ultimately trigger the background worker to flush
server.Dispose();

await Verify(new { result, transport.Payloads })
.IgnoreStandardSentryMembers()
.ScrubAspMembers()
.UniqueForTargetFrameworkAndVersion();
// No transaction should be recorded for pre-flight/options requests
// See: https://github.com/getsentry/sentry-dotnet/issues/1835#issuecomment-1239546099
transport.Payloads.Any().Should().BeFalse();
}

[ApiController]
Expand Down
Loading