ref: remove incr_version / decr_version #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile-sentry
force-pushed
the
remove-incr-decr
branch
from
9bbcb1e to
ed871b3
Compare
these methods are unsafe with our usage of cache
asottile-sentry
force-pushed
the
remove-incr-decr
branch
from
ed871b3 to
3d5f529
Compare
joshuarli
approved these changes
Jun 14, 2024
asottile-sentry
added a commit
that referenced
this pull request
Jul 31, 2024
these methods are unsafe with our usage of cache
asottile-sentry
added a commit
that referenced
this pull request
Sep 24, 2024
these methods are unsafe with our usage of cache
asottile-sentry
added a commit
that referenced
this pull request
Oct 28, 2024
these methods are unsafe with our usage of cache
asottile-sentry
added a commit
that referenced
this pull request
Jan 14, 2025
these methods are unsafe with our usage of cache
asottile-sentry
added a commit
that referenced
this pull request
Feb 7, 2025
these methods are unsafe with our usage of cache
asottile-sentry
added a commit
that referenced
this pull request
Apr 28, 2025
these methods are unsafe with our usage of cache
asottile-sentry
added a commit
that referenced
this pull request
Jun 17, 2025
these methods are unsafe with our usage of cache
asottile-sentry
added a commit
that referenced
this pull request
Jul 21, 2025
these methods are unsafe with our usage of cache
asottile-sentry
added a commit
that referenced
this pull request
Sep 12, 2025
these methods are unsafe with our usage of cache
asottile-sentry
added a commit
that referenced
this pull request
Sep 15, 2025
This reverts commit 1020f9a.
asottile-sentry
added a commit
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these methods are unsafe with our usage of cache
we use
strfor cache version as a hashed value of model fields -- these methods manipulate version as anint-- fortunately we never use them