Skip to content

Commit 1b0f711

Browse files
committed
Fix orgId fallback for blank configured values
1 parent 863f05b commit 1b0f711

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

sentry/src/main/java/io/sentry/SentryOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2337,7 +2337,7 @@ public void setOrgId(final @Nullable String orgId) {
23372337
*/
23382338
@ApiStatus.Internal
23392339
public @Nullable String getEffectiveOrgId() {
2340-
if (orgId != null) {
2340+
if (orgId != null && !orgId.trim().isEmpty()) {
23412341
return orgId;
23422342
}
23432343
try {

sentry/src/test/java/io/sentry/SentryOptionsTest.kt

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,6 +1019,19 @@ class SentryOptionsTest {
10191019
assertEquals("999", options.effectiveOrgId)
10201020
}
10211021

1022+
@Test
1023+
fun `getEffectiveOrgId falls back to DSN org id when explicit orgId is empty or blank`() {
1024+
val emptyOrgIdOptions = SentryOptions()
1025+
emptyOrgIdOptions.dsn = "https://key@o123.ingest.sentry.io/456"
1026+
emptyOrgIdOptions.orgId = ""
1027+
assertEquals("123", emptyOrgIdOptions.effectiveOrgId)
1028+
1029+
val blankOrgIdOptions = SentryOptions()
1030+
blankOrgIdOptions.dsn = "https://key@o123.ingest.sentry.io/456"
1031+
blankOrgIdOptions.orgId = " "
1032+
assertEquals("123", blankOrgIdOptions.effectiveOrgId)
1033+
}
1034+
10221035
@Test
10231036
fun `getEffectiveOrgId falls back to DSN org id`() {
10241037
val options = SentryOptions()

0 commit comments

Comments
 (0)