Skip to content

Conversation

@bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jan 21, 2021

📜 Description

Removed a check box.

💡 Motivation and Context

I need to wait for CI to see if it passed before I can check the checkbox. No much value in that.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@marandaneto
Copy link
Contributor

so you know that you need to run the build/tests locally :) that's the value.
at least for me, its helpful, sometimes I forget to run the tests and they are broken, that checkbox makes me do that.
no strong opinions here, maybe @philipphofmann

@philipphofmann philipphofmann changed the title ref: remove PR template tests pass checkbox meta: Remove PR template tests pass checkbox Jan 21, 2021
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removing it. If you forgot to run them locally, the CI is going to tell you.

@philipphofmann
Copy link
Member

If we are already improving the PR template: #1197

@bruno-garcia bruno-garcia merged commit b668630 into main Jan 21, 2021
@bruno-garcia bruno-garcia deleted the ref/remove-pr-template-checkbox-tests-pass branch January 21, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants