Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 2, 2021

📜 Description

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto marked this pull request as draft July 2, 2021 07:50
@marandaneto
Copy link
Contributor Author

merge after getsentry/craft#258

@codecov-commenter
Copy link

Codecov Report

Merging #1577 (188517f) into main (a6f5e1b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1577   +/-   ##
=========================================
  Coverage     76.02%   76.02%           
  Complexity     1974     1974           
=========================================
  Files           198      198           
  Lines          6837     6837           
  Branches        680      680           
=========================================
  Hits           5198     5198           
  Misses         1306     1306           
  Partials        333      333           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f5e1b...188517f. Read the comment docs.

@marandaneto marandaneto marked this pull request as ready for review July 3, 2021 11:56
@bruno-garcia bruno-garcia merged commit 3739f67 into main Jul 8, 2021
@bruno-garcia bruno-garcia deleted the fix/remove-make-release branch July 8, 2021 17:21
@marandaneto
Copy link
Contributor Author

@bruno-garcia we might need to revert this, will check that later, craft isn't released yet, so it'll fail because of minVersion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants