Skip to content

Conversation

@iker-barriocanal
Copy link
Contributor

From Craft docs:

The script is responsible for any and all git state management as craft will simply exit after running this script as the final step. This means the script is responsible for committing and pushing any changes that it may have made.

Git state isn't managed in the post-release script, meaning changes won't be pushed; this PR manages it.

#skip-changelog

@marandaneto
Copy link
Contributor

@iker-barriocanal there's a conflict, besides that, LGTM

@iker-barriocanal iker-barriocanal merged commit a407398 into main Jul 13, 2021
@iker-barriocanal iker-barriocanal deleted the iker/fix/postrelease-push branch July 13, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants