Skip to content

Conversation

@iker-barriocanal
Copy link
Contributor

@iker-barriocanal iker-barriocanal commented Jul 12, 2021

This PR adds the symbol-collector target to support getsentry/craft#266. It also changes the target order, so that:

  • symbol-collector runs before maven, since the former is reentrant and the latter isn't.
  • github and registry targets go after symbol-collector and maven, since the first two should only be run once the actual release has been made.

#skip-changelog

@codecov-commenter
Copy link

Codecov Report

Merging #1592 (6b6763f) into main (3739f67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1592   +/-   ##
=========================================
  Coverage     76.02%   76.02%           
  Complexity     1974     1974           
=========================================
  Files           198      198           
  Lines          6837     6837           
  Branches        680      680           
=========================================
  Hits           5198     5198           
  Misses         1306     1306           
  Partials        333      333           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3739f67...6b6763f. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bruno-garcia bruno-garcia merged commit fe08f51 into main Jul 12, 2021
@bruno-garcia bruno-garcia deleted the iker/feat/symbol-collector-target branch July 12, 2021 16:28
@marandaneto
Copy link
Contributor

@iker-barriocanal requires https://github.com/getsentry/craft to be released, and updating https://github.com/getsentry/sentry-java/blob/main/.craft.yml#L1 if necessary, right now it requires building craft manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants