Skip to content

Conversation

@stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Sep 21, 2022

📜 Description

This pr is still a draft: Saucelabs has issues with its Android 13 devices (they are never available). As soon as Saucelabs fixes it, we will merge it into master
We added an Android 13 device on the Saucelabs suite running ui tests

#skip-changelog

💡 Motivation and Context

We want to make sure the Android sdk works correctly on the latest Android version, currently 13

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@stefanosiano stefanosiano mentioned this pull request Sep 21, 2022
4 tasks
@marandaneto
Copy link
Contributor

@stefanosiano I'd also build the app using compile and target 33, otherwise, it does not test the SDK compatibility as well.

@stefanosiano
Copy link
Member Author

@marandaneto yeah, this is meant to be merged after #2251
Maybe i can change the base to android_target_sdk_33?

@codecov-commenter
Copy link

Codecov Report

Base: 80.10% // Head: 80.11% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (34ddc64) compared to base (4dd88fe).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2252      +/-   ##
============================================
+ Coverage     80.10%   80.11%   +0.01%     
- Complexity     3423     3426       +3     
============================================
  Files           242      242              
  Lines         12692    12696       +4     
  Branches       1698     1698              
============================================
+ Hits          10167    10172       +5     
+ Misses         1882     1881       -1     
  Partials        643      643              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/Baggage.java 82.58% <0.00%> (+0.46%) ⬆️
sentry/src/main/java/io/sentry/HubAdapter.java 9.52% <0.00%> (+1.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano marked this pull request as ready for review October 12, 2022 09:09
@stefanosiano
Copy link
Member Author

stefanosiano commented Oct 12, 2022

I had to put two beta versions: androidx.test:core:1.5.0-beta01 and androidx.test:core-ktx:1.5.0-beta01
Should we wait for them to be released in stable (1.5.0) or can we just go with beta and then change them to stable as it is available?
These dependencies are used only in ui tests and benchmarks, so other modules of the sdk are unaffected

@romtsn
Copy link
Member

romtsn commented Oct 12, 2022

I had to put two beta versions: androidx.test:core:1.5.0-beta01 and androidx.test:core-ktx:1.5.0-beta01 Should we wait for them to be released in stable (1.5.0) or can we just go with beta and then change them to stable as it is available? These dependencies are used only in ui tests and benchmarks, so other modules of the sdk are unaffected

I think it's fine since those are test deps 👍

@stefanosiano stefanosiano merged commit 9c3b569 into main Oct 12, 2022
@stefanosiano stefanosiano deleted the tests/uitests-android13 branch October 12, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants