Skip to content

POTEL 54 - Cleanup #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 11, 2024
Merged

POTEL 54 - Cleanup #3861

merged 8 commits into from
Nov 11, 2024

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Nov 8, 2024 •
edited
Loading

#skip-changelog

📜 Description

Addresses comments from previous PRs

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0c33105

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 411.02 ms 471.62 ms 60.60 ms
Size 1.70 MiB 2.36 MiB 671.45 KiB

lbloder
lbloder approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/spanfactoryfactory to 8.x.x November 11, 2024 15:38
@adinauer adinauer merged commit a619788 into 8.x.x Nov 11, 2024
14 of 19 checks passed
@adinauer adinauer deleted the feat/potel-54-cleanup branch November 11, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adinauer @lbloder