Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Nov 12, 2024

#skip-changelog

📜 Description

Port Spring Boot 3 OpenTelemetry changes to Spring Boot 2

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e386289

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 422.41 ms 451.14 ms 28.73 ms
Size 1.65 MiB 2.31 MiB 672.90 KiB

Previous results on branch: feat/spring-boot-2-otel

Startup times

Revision Plain With Sentry Diff
b531ccb 370.52 ms 431.92 ms 61.40 ms

App size

Revision Plain With Sentry Diff
b531ccb 1.65 MiB 2.31 MiB 672.90 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration names need to be adapted, otherwise LGTM 👍

Co-authored-by: Lukas Bloder <lukas.bloder@gmail.com>
@adinauer adinauer merged commit fe2c403 into 8.x.x Nov 12, 2024
24 of 27 checks passed
@adinauer adinauer deleted the feat/spring-boot-2-otel branch November 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants