-
-
Couldn't load subscription status.
- Fork 460
feat(replay): Add Mask/Unmask Containers for custom masking in hybrid SDKs #3881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 95d3a46 | 403.06 ms | 421.08 ms | 18.02 ms |
| 4db467c | 450.15 ms | 464.73 ms | 14.59 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 95d3a46 | 1.70 MiB | 2.35 MiB | 668.48 KiB |
| 4db467c | 1.70 MiB | 2.35 MiB | 668.47 KiB |
sentry-android-replay/src/main/java/io/sentry/android/replay/viewhierarchy/ViewHierarchyNode.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor thing, but lgtm otherwise!
|
btw, I'd also love to have a changelog entry for this, in case this causes problems we can always see it in the version history - this has bitten me in the past already a few times |
|
@romtsn Thank you for the review and updates. |
📜 Description
This PR adds masking containers for hybrid SDKs like RN.
RN implements ReactViewGroup Mask and Unmask on Android. These classes can be used from JS to custom mask elements.
This PR exposes options to set the implemented containers and used them for custom masking.
💚 How did you test it?
rn sample app, integration tests
📝 Checklist
sendDefaultPIIis enabled.