Skip to content

Conversation

@markushi
Copy link
Member

Requires to use synchronized blocks over AutoClosableReentrantLock, as only the bitmap object is shared across Strategy <-> ReplayCache. This ensure bitmap.compress is not called in parallel to bitmap.recycle

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Requires to use synchronized blocks over AutoClosableReentrantLock, as
only the bitmap object is shared across Strategy <-> ReplayCache.
This ensure bitmap.compress is not called in parallel to bitmap.recycle
cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 306.81 ms 372.66 ms 65.85 ms
Size 1.58 MiB 2.12 MiB 549.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d364ace 411.72 ms 430.81 ms 19.10 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms
889ecea 367.58 ms 437.52 ms 69.94 ms
b77456b 393.26 ms 441.10 ms 47.84 ms
f634d01 375.06 ms 420.04 ms 44.98 ms
b750b96 408.98 ms 480.32 ms 71.34 ms
b3d8889 371.69 ms 432.96 ms 61.26 ms
9fbb112 401.87 ms 515.87 ms 114.00 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms

App size

Revision Plain With Sentry Diff
d364ace 1.58 MiB 2.11 MiB 539.75 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
889ecea 1.58 MiB 2.11 MiB 539.75 KiB
b77456b 1.58 MiB 2.12 MiB 548.11 KiB
f634d01 1.58 MiB 2.10 MiB 533.40 KiB
b750b96 1.58 MiB 2.10 MiB 533.19 KiB
b3d8889 1.58 MiB 2.10 MiB 535.06 KiB
9fbb112 1.58 MiB 2.11 MiB 539.18 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: markushi/fix/sr-bitmap-synchronization

Startup times

Revision Plain With Sentry Diff
22d6c54 328.67 ms 392.40 ms 63.73 ms
735b63e 303.80 ms 366.12 ms 62.32 ms
92f4581 300.64 ms 362.88 ms 62.24 ms
2cdc160 313.60 ms 367.83 ms 54.23 ms

App size

Revision Plain With Sentry Diff
22d6c54 1.58 MiB 2.12 MiB 548.19 KiB
735b63e 1.58 MiB 2.12 MiB 549.49 KiB
92f4581 1.58 MiB 2.12 MiB 549.49 KiB
2cdc160 1.58 MiB 2.12 MiB 549.42 KiB

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one bugbot thing, but lgtm otherwise

cursor[bot]

This comment was marked as outdated.

@markushi markushi changed the title [SR] Synchronize Bitmap modifications [SR] Ensure bitmaps are recycled properly Oct 22, 2025
cursor[bot]

This comment was marked as outdated.

@markushi markushi merged commit b698afe into main Oct 22, 2025
60 of 61 checks passed
@markushi markushi deleted the markushi/fix/sr-bitmap-synchronization branch October 22, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants