Use browserify to generate plugin versions of raven

Author: benvinegar

Gruntfile.js

@@ -1,8 +1,10 @@
+
 module.exports = function(grunt) {
     "use strict";
 
     var _ = require('lodash');
     var path = require('path');
+    var through = require('through2');
 
     var excludedPlugins = [
         'react-native'
@@ -58,7 +60,7 @@ module.exports = function(grunt) {
         key.sort();
 
         var dest = path.join('build/', key.join(','), '/raven.js');
-        dict[dest] = ['build/raven.js'].concat(comb);
+        dict[dest] = ['src/raven.js'].concat(comb);
 
         return dict;
     }, {});
@@ -68,26 +70,38 @@ module.exports = function(grunt) {
         aws: grunt.file.exists('aws.json') ? grunt.file.readJSON('aws.json'): {},
 
         clean: ['build'],
-        concat: {
-            options: {
-                separator: '\n',
-                process: true
-            },
-            plugins: {
-                files: pluginConcatFiles
-            }
-        },
 
         browserify: {
+            options: {
+                browserifyOptions: {
+                    banner: grunt.file.read('template/_copyright.js'),
+                    standalone: 'Raven', // umd
+                },
+                transform: [
+                    [
+                        // custom transformer to re-write plugins to self-register
+                        // with Raven
+                        new function () {
+                            return function (file, options) {
+                                return through(function (buf, enc, next) {
+                                    var buf = buf.toString('utf8');
+                                    if (/plugins/.test(file)) {
+                                        buf += "\nRaven.addPlugin(module.exports.install);";
+                                    }
+                                    this.push(buf);
+                                    next();
+                                });
+                            }
+                        }
+                    ]
+                ]
+            },
             core: {
                 src: 'src/raven.js',
                 dest: 'build/raven.js',
-                options: {
-                    banner: grunt.file.read('template/_copyright.js'),
-                    browserifyOptions: {
-                        standalone: 'Raven' // umd
-                    }
-                }
+            },
+            plugins: {
+                files: pluginConcatFiles
             }
         },
 
@@ -252,15 +266,13 @@ module.exports = function(grunt) {
 
     // Grunt contrib tasks
     grunt.loadNpmTasks('grunt-contrib-uglify');
-    grunt.loadNpmTasks('grunt-contrib-concat');
     grunt.loadNpmTasks('grunt-contrib-clean');
     grunt.loadNpmTasks('grunt-contrib-jshint');
     grunt.loadNpmTasks('grunt-contrib-connect');
     grunt.loadNpmTasks('grunt-contrib-copy');
 
     // 3rd party Grunt tasks
     grunt.loadNpmTasks('grunt-browserify');
-    grunt.loadNpmTasks('grunt-exorcise');
     grunt.loadNpmTasks('grunt-mocha');
     grunt.loadNpmTasks('grunt-release');
     grunt.loadNpmTasks('grunt-s3');
@@ -269,10 +281,10 @@ module.exports = function(grunt) {
 
     // Build tasks
     grunt.registerTask('_prep', ['clean', 'gitinfo', 'version']);
-    grunt.registerTask('concat.core', ['browserify', 'exorcise']);
-    grunt.registerTask('concat.plugins', ['concat:plugins']);
-    grunt.registerTask('build.core', ['_prep', 'concat.core', 'uglify', 'fixSourceMaps', 'sri:dist']);
-    grunt.registerTask('build.all', ['_prep', 'concat.core', 'concat.plugins', 'uglify', 'fixSourceMaps', 'sri:dist', 'sri:build']);
+    grunt.registerTask('browserify.core', ['_prep', 'browserify:core']);
+    grunt.registerTask('browserify.plugins', ['_prep', 'browserify:plugins']);
+    grunt.registerTask('build.core', ['browserify.core', 'uglify', 'fixSourceMaps', 'sri:dist']);
+    grunt.registerTask('build.all', ['browserify.plugins', 'uglify', 'fixSourceMaps', 'sri:dist', 'sri:build']);
     grunt.registerTask('build', ['build.all']);
     grunt.registerTask('dist', ['build.core', 'copy:dist']);
 

package.json

@@ -30,7 +30,8 @@
     "grunt-sri": "mattrobenolt/grunt-sri#pretty",
     "jquery": "^2.1.4",
     "lodash": "~2.4.0",
-    "sinon": "~1.7.3"
+    "sinon": "~1.7.3",
+    "through2": "^2.0.0"
   },
   "keywords": [
     "exceptions",

plugins/angular.js

@@ -3,14 +3,8 @@
  *
  * Provides an $exceptionHandler for Angular.js
  */
-;(function(window) {
-'use strict';
 
-var angular = window.angular,
-    Raven = window.Raven;
-
-// quit if angular isn't on the page
-if (!(angular && Raven)) return;
+var Raven = require('../src/raven');
 
 function RavenProvider() {
     this.$get = ['$window', function($window, $log) {
@@ -35,28 +29,33 @@ function exceptionHandler(Raven, $delegate) {
 // See https://github.com/angular/angular.js/blob/v1.4.7/src/minErr.js
 var angularPattern = /^\[((?:[$a-zA-Z0-9]+:)?(?:[$a-zA-Z0-9]+))\] (.+?)\n(\S+)$/;
 
-Raven.addPlugin(function () {
+function install() {
+    var angular = window.angular;
+    if (!angular) return;
+
     angular.module('ngRaven', [])
         .provider('Raven',  RavenProvider)
         .config(['$provide', ExceptionHandlerProvider]);
-});
-
-Raven.setDataCallback(function(data) {
-    // We only care about mutating an exception
-    var exception = data.exception;
-    if (exception) {
-        exception = exception.values[0];
-        var matches = angularPattern.exec(exception.value);
-
-        if (matches) {
-            // This type now becomes something like: $rootScope:inprog
-            exception.type = matches[1];
-            exception.value = matches[2];
-            data.message = exception.type + ': ' + exception.value;
-            // auto set a new tag specifically for the angular error url
-            data.extra.angularDocs = matches[3].substr(0, 250);
+
+    Raven.setDataCallback(function(data) {
+        // We only care about mutating an exception
+        var exception = data.exception;
+        if (exception) {
+            exception = exception.values[0];
+            var matches = angularPattern.exec(exception.value);
+
+            if (matches) {
+                // This type now becomes something like: $rootScope:inprog
+                exception.type = matches[1];
+                exception.value = matches[2];
+                data.message = exception.type + ': ' + exception.value;
+                // auto set a new tag specifically for the angular error url
+                data.extra.angularDocs = matches[3].substr(0, 250);
+            }
         }
-    }
-});
+    });
+}
 
-}(typeof window !== 'undefined' ? window : this));
+module.exports = {
+    install: install
+};