fix tests

Author: mydea

packages/replay/src/eventBuffer/EventBufferProxy.ts

@@ -14,13 +14,16 @@ export class EventBufferProxy implements EventBuffer {
   private _fallback: EventBufferArray;
   private _compression: EventBufferCompressionWorker;
   private _used: EventBuffer;
+  private _ensureWorkerIsLoadedPromise: Promise<void>;
 
   public constructor(worker: Worker) {
     this._fallback = new EventBufferArray();
     this._compression = new EventBufferCompressionWorker(worker);
     this._used = this._fallback;
 
-    void this.ensureWorkerIsLoaded();
+    this._ensureWorkerIsLoadedPromise = this._ensureWorkerIsLoaded().catch(() => {
+      // Ignore errors here
+    });
   }
 
   /** @inheritDoc */
@@ -51,17 +54,18 @@ export class EventBufferProxy implements EventBuffer {
   /** @inheritDoc */
   public async finish(): Promise<ReplayRecordingData> {
     // Ensure the worker is loaded, so the sent event is compressed
-    try {
-      await this.ensureWorkerIsLoaded();
-    } catch (error) {
-      // If this fails, we'll just send uncompressed events
-    }
+    await this.ensureWorkerIsLoaded();
 
     return this._used.finish();
   }
 
   /** Ensure the worker has loaded. */
-  public async ensureWorkerIsLoaded(): Promise<void> {
+  public ensureWorkerIsLoaded(): Promise<void> {
+    return this._ensureWorkerIsLoadedPromise;
+  }
+
+  /** Actually check if the worker has been loaded. */
+  private async _ensureWorkerIsLoaded(): Promise<void> {
     try {
       await this._compression.ensureReady();
     } catch (error) {

packages/replay/test/unit/eventBuffer.test.ts

@@ -132,6 +132,7 @@ describe('Unit | eventBuffer', () => {
       buffer.addEvent(TEST_EVENT);
 
       const promise1 = buffer.finish();
+      await new Promise(process.nextTick);
 
       buffer.addEvent({ ...TEST_EVENT, type: 5 });
       const promise2 = buffer.finish();
@@ -146,7 +147,7 @@ describe('Unit | eventBuffer', () => {
       expect(restored2).toEqual(JSON.stringify([{ ...TEST_EVENT, type: 5 }]));
     });
 
-    it('handles an error when compressing the payload xxx', async function () {
+    it('handles an error when compressing the payload', async function () {
       const buffer = createEventBuffer({
         useCompression: true,
       }) as EventBufferProxy;
@@ -184,7 +185,7 @@ describe('Unit | eventBuffer', () => {
       consoleErrorSpy.mockRestore();
     });
 
-    it('first uses simple buffer, and switches over once worker is loaded', async function () {
+    it('waits for the worker to be loaded when calling finish', async function () {
       const buffer = createEventBuffer({
         useCompression: true,
       }) as EventBufferProxy;
@@ -196,26 +197,10 @@ describe('Unit | eventBuffer', () => {
 
       expect(buffer.pendingEvents).toEqual([TEST_EVENT, TEST_EVENT]);
 
-      // Finish before the worker is loaded
       const result = await buffer.finish();
-      expect(typeof result).toBe('string');
-      expect(result).toEqual(JSON.stringify([TEST_EVENT, TEST_EVENT]));
-
-      // Now actually finish loading the worker
-      await buffer.ensureWorkerIsLoaded();
-
-      buffer.addEvent(TEST_EVENT);
-      buffer.addEvent(TEST_EVENT);
-      buffer.addEvent(TEST_EVENT);
-
-      expect(buffer.pendingEvents).toEqual([TEST_EVENT, TEST_EVENT, TEST_EVENT]);
-
-      const result2 = await buffer.finish();
-      expect(result2).toBeInstanceOf(Uint8Array);
-
-      const restored2 = pako.inflate(result2 as Uint8Array, { to: 'string' });
-
-      expect(restored2).toEqual(JSON.stringify([TEST_EVENT, TEST_EVENT, TEST_EVENT]));
+      expect(result).toBeInstanceOf(Uint8Array);
+      const restored = pako.inflate(result as Uint8Array, { to: 'string' });
+      expect(restored).toEqual(JSON.stringify([TEST_EVENT, TEST_EVENT]));
     });
 
     it('keeps using simple buffer if worker cannot be loaded', async function () {