fix: remove unsafe ‘any' from NodeOptions type#2111
Merged
kamilogorek merged 2 commits intogetsentry:masterfrom Jul 5, 2019
Merged
fix: remove unsafe ‘any' from NodeOptions type#2111kamilogorek merged 2 commits intogetsentry:masterfrom
kamilogorek merged 2 commits intogetsentry:masterfrom
Conversation
Contributor
|
Thanks! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
NodeOptionsare not typed because [key: string]: any matches any key.FYI, I was unable to get lerna (yes I am familiar how it works and followed Contributing as well) to properly install so I am unable to check if typescript still passes.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).