fix(utils/object): fix normalizing error from null#2305
Merged
kamilogorek merged 2 commits intogetsentry:masterfrom Nov 11, 2019
gordomium:fix/object-with-domain-as-non-serializable
Merged
fix(utils/object): fix normalizing error from null#2305kamilogorek merged 2 commits intogetsentry:masterfrom gordomium:fix/object-with-domain-as-non-serializable
kamilogorek merged 2 commits intogetsentry:masterfrom
gordomium:fix/object-with-domain-as-non-serializable
Conversation
kamilogorek
suggested changes
Nov 10, 2019
Contributor
kamilogorek
left a comment
kamilogorek
left a comment
There was a problem hiding this comment.
Those functions are written correctly, the bug is inside the first check of normalizeValue.
if (key === 'domain' && typeof value === 'object' && ((value as unknown) as { _events: any })._events) {This typeof value === 'object' is a false positive for null (classic JS), and it requires a change to:
if (key === 'domain' && value && ((value as unknown) as { _events: any })._events) {Thanks!
kamilogorek
approved these changes
Nov 11, 2019
HazAT
added a commit
that referenced
this pull request
Nov 15, 2019
* master: release: 5.9.0 feat: Introduce mode option for global promise handler in node (#2312) release: 5.8.0 misc: 5.8.0 changelog update fix(utils/object): fix normalizing error from null (#2305) doc: Link to discord, not IRC (#2304) fix: Skip empty filename in frames and fallback to location chore: Linter auto-fixes misc: 5.8.0 changelog chore: replace several instances of any (#2264) feat: 429 http code handling in node/browser transports ref: Remove dom references from utils for old TS and env interop fix: Gracefuly handle incorrect input from onerror feat: Make sure that Debug integration is always setup as the last one # Conflicts: # lerna.json # packages/browser/package.json # packages/browser/src/version.ts # packages/core/package.json # packages/hub/package.json # packages/integrations/package.json # packages/minimal/package.json # packages/node/package.json # packages/node/src/version.ts # packages/utils/package.json # packages/utils/src/misc.ts
This was referenced Dec 12, 2019
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sentry captured extra serialization
got
**non-serializable**，because ofCannot read property '_events' of null