Optimize supportsNativeFetch() with a fast path that avoids DOM I/O#2326
Merged
HazAT merged 2 commits intogetsentry:masterfrom Nov 27, 2019
AaronO:optimize/native-fetch-check
Merged
Optimize supportsNativeFetch() with a fast path that avoids DOM I/O#2326HazAT merged 2 commits intogetsentry:masterfrom AaronO:optimize/native-fetch-check
HazAT merged 2 commits intogetsentry:masterfrom
AaronO:optimize/native-fetch-check
Conversation
HazAT
approved these changes
Nov 26, 2019
Member
HazAT
left a comment
HazAT
left a comment
There was a problem hiding this comment.
Thanks for the issue report + nice PR!
LGTM wdyt @kamilogorek
Contributor
|
Looks much better now. Thanks! Feel free to merge @HazAT |
Contributor
Author
|
@HazAT Thanks for merging this, any idea of when it will be shipped in a release ? |
Member
|
We are in the process of releasing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2324 by adding a fast path for the scenario where the browser supports
fetchandwindow.fetchhasn't been wrapped or polyfilled (which should be very common on modern browsers)This avoids expensive DOM I/O in the critical path during the initial load.
Fallbacking to the expensive iframe check, if necessary.
Note
The new
isNativeFetch()check is also more robust than the previous implementation, which could yield false positives (since it only checked if the function's body containednative).