ref: Rework XHR wrapping logic to make sure it always triggers#2438
Merged
kamilogorek merged 2 commits intomasterfrom Feb 19, 2020
Merged
ref: Rework XHR wrapping logic to make sure it always triggers#2438kamilogorek merged 2 commits intomasterfrom
kamilogorek merged 2 commits intomasterfrom
Conversation
Contributor
HazAT
requested changes
Feb 18, 2020
kamilogorek
force-pushed
the
apm-xhr-warning
branch
2 times, most recently
from
54c2dc9 to
1b21167
Compare
kamilogorek
changed the title
kamilogorek
force-pushed
the
apm-xhr-warning
branch
4 times, most recently
from
64235d4 to
6dc4ffd
Compare
HazAT
requested changes
Feb 19, 2020
| assert.equal(summary.breadcrumbs[0].type, "http"); | ||
| assert.equal(summary.breadcrumbs[0].category, "xhr"); | ||
| assert.equal(summary.breadcrumbs[0].data.method, "GET"); | ||
| assert.typeOf(summary.breadcrumbs[0].timestamp, "number"); |
Member
There was a problem hiding this comment.
Shouldn't we check for endTimestamp to make sure we actually got what we wanted?
Contributor
Author
There was a problem hiding this comment.
There's not registered handler for this in breadcrumbs without an amp package :3
I'll see if we can go around this somehow.
kamilogorek
force-pushed
the
apm-xhr-warning
branch
from
6dc4ffd to
48f452d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.