ref: Doesnt allow for popping last layer and unify getter methods#2955
Merged
kamilogorek merged 1 commit intomasterfrom Oct 7, 2020
Merged
ref: Doesnt allow for popping last layer and unify getter methods#2955kamilogorek merged 1 commit intomasterfrom
kamilogorek merged 1 commit intomasterfrom
Conversation
Contributor
size-limit report
|
kamilogorek
requested review from
HazAT and
rhcarvalho
and removed request for
rhcarvalho
HazAT
approved these changes
Oct 7, 2020
rhcarvalho
reviewed
Oct 7, 2020
| if (finalBreadcrumb === null) { | ||
| return; | ||
| } | ||
| if (finalBreadcrumb === null) return; |
Contributor
There was a problem hiding this comment.
Not a big fan of if without {}, a bit harder to read when scanning quickly through code, easier to introduce bugs. (isn't there a linter rule for this?!)
On top of that this change is introducing inconsistency in style. For example, later in this file:
| public popScope(): boolean { | ||
| return this.getStack().pop() !== undefined; | ||
| if (this.getStack().length <= 1) return false; | ||
| return !!this.getStack().pop(); |
Contributor
There was a problem hiding this comment.
This could be accessing this._stack directly, same in pushScope.
Why is there even a public getStack()?! Is there a use case to deal with stack layers from code external to this class?!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preventing the popping of the last layer makes it in line with
sentry-pythonbehavior. It didn't make much sense to allow that in the first place. Because of that change, during construction, it'll update the initially empty layer instead of pushing a new one.