Add optional parameter to AWSServices integration#3030
Merged
HazAT merged 1 commit intogetsentry:masterfrom Nov 12, 2020
Merged
Add optional parameter to AWSServices integration#3030HazAT merged 1 commit intogetsentry:masterfrom
optional parameter to AWSServices integration#3030HazAT merged 1 commit intogetsentry:masterfrom
Conversation
Initially, I thought there's no need to catch the error of
`require('aws-sdk/global')` because this package is always available on
AWS Lambda and even in the `sam local` emulator.
However, in some environments it could be missing. Examples of such
environments is netlify dev or it could be simply a unit-test environment
without any packages.
Fixes getsentry#3000.
kamilogorek
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, I thought there's no need to catch the error of
require('aws-sdk/global')because this package is always available on AWS Lambda and even in thesam localemulator.However, in some environments it could be missing. Examples of such environments is netlify dev or it could be simply a unit-test environment without any packages.
Fixes #3000.