feat(browser): Envelope tunnel support for browser #3521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
HazAT
previously requested changes
May 21, 2021
packages/browser/src/backend.ts
Outdated
| const transportOptions = { | ||
| ...this._options.transportOptions, | ||
| dsn: this._options.dsn, | ||
| envelopeTunnel: this._options.envelopeTunnel, |
Member
There was a problem hiding this comment.
I would prefer if we call this option only tunnel.
Users don't care and understand what an envelope is and I would consider it an implementation detail.
Contributor
Author
There was a problem hiding this comment.
I’m fine calling it just tunnel.
Contributor
8 tasks
kamilogorek
force-pushed
the
feature/envelope-tunnel
branch
from
08bdd97 to
314149c
Compare
kamilogorek
dismissed
HazAT’s stale review
Already approved earlier, rebased on master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non working WIP implementation of adding a mode to the JavaScript SDK to work around ad blockers blocking traffic.
The idea is that if a URL is configured with
envelopeTunnelthe transport forces all events to be sent as envelopes (with embedded auth), no url parameters are configured and the submission URL is the given tunnel URL instead of the regular one.This is intended to address getsentry/sentry#25607