ci(replay): Overhead measurement#6611
Conversation
2d7bad6 to
88ae1ec
Compare
Lms24
left a comment
There was a problem hiding this comment.
Hi @vaind! Great to see progress on the overhead measurements!
I haven't looked too closely over this PR but I was just wondering if there's a specific reason you chose puppeteer over e.g. playwright? The reason I'm asking is that long-term, we'd like to remove Puppeteer in favour of Playwright as it's causing quite a few issues for us and we'Ve had good experiences with Playwright so far. Therefore I'd like to avoid using it in new projects we add to the repo.
I know that you're not yet finished but feel free to tag me or anyone from the team if you have questions. Cheers!
|
Thanks for having a first look @Lms24. As for Puppeteer - no specific reason, I've seen it used somewhere in the repo so went for it. Switched to playwright now 👍 |
05c34af to
a6869aa
Compare
af04359 to
7a4e90f
Compare
60d0b62 to
77fa886
Compare
Lms24
left a comment
There was a problem hiding this comment.
Thanks for addressing our feedback! Will merge it soon
Thanks to @vaind for their initial work on this at getsentry/sentry-javascript#6611. We wanted to extract this to a separate tool so it can be run outside of the `sentry-javascript` repo.
implements #6503
Progress:
Outstanding/known issues