test(nextjs): Add NextJS server-side E2E tests.#6829
Merged
Conversation
3699745 to
1f91ad2
Compare
Contributor
size-limit report 📦
|
8715ff5 to
5bf058a
Compare
5bf058a to
565bb80
Compare
lforst
approved these changes
Jan 23, 2023
Contributor
lforst
left a comment
There was a problem hiding this comment.
Nice! I like the the approach of just using the playwright runner 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #6292
Added 2 server-side behaviour tests in the
create-next-apptest application.This set of tests use Playwright as their runner, but they don't use the browser functionality of it. This is for simplicity and also consistency, as
expect.pollis not available in jest runners.Not sure triggering a server-side error through a user interaction on browser will make a difference for E2E tests, but it's also an option with this setup.
The
event/transactionids are returned to the test environment as HTTP responses from the server.If the team agrees, this approach has a potential to be generalised while writing other server-side tests. Not updating README for now.