fix(tests): Use the default Playwright timeouts.#6870
Merged
AbhiPrasad merged 1 commit intomasterfrom Jan 23, 2023
Merged
Conversation
Contributor
size-limit report 📦
|
0aa8847 to
d1ad6f1
Compare
d1ad6f1 to
e42bbdc
Compare
AbhiPrasad
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #6848
Resolves: #6872
Updating Playwright configurations to use the default 30 seconds, instead of 12 seconds configured. Not sure why we decreased the test timeout in the first place.
The case in #6848 happens randomly in any test in the same file, so I suspect this is just about the shortened timeout, rather than certain implementation / test that trigger flaking.
Testing here to check if there is a hanging test that hits the default 30 seconds.
Edit: No flakes for #6848 or #6872 after 9 CI trials on this PR.