chore: collect replay network metrics#6881
Merged
Lms24 merged 1 commit intogetsentry:masterfrom Jan 26, 2023
Merged
Conversation
mydea
reviewed
Jan 20, 2023
vaind
force-pushed
the
chore/metrics-network
branch
from
e82ddbd to
601ca51
Compare
Lms24
approved these changes
Jan 23, 2023
Member
There was a problem hiding this comment.
EDIT: I accidentally approved this PR and can't dismiss it as it's still a draft. LMK when this is ready for review, then I'll give it another look.
Very interesting! For future readers and because I'm also not a 100% certain I understood correctly what's going on: Could you add a small description of what these additional metrics mean in the context of our SDK/replay? Is it the amount of bytes the SDK sent/received?
Contributor
Author
|
@Lms24 it's OK, I just didn't change it from draft back then because I wanted to wait for the CI to pass on my own fork first. Just made the change to a ready PR without any more commits so your review is valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds network info to the collected metrics - it shows the amount of data sent (Net Tx) and received (Net Rx) by the browser. It works by intercepting the network requests with a custom handler that logs the transmission stats. Because Sentry SDK is the only application code sending requests, it equals the amount of data sent & received by the SDK. You can see in the example below that because there are no errors triggered, there's no data sent/received with just the plain Sentry SDK; there's network traffic only when Replay is added.
Currently, only HTTP requests are captured, no
file:///URLs (these are used to load the actual page and scripts from the local filesystem).vaind#2 (comment)