Conversation
added 2 commits
January 24, 2023 15:44
Lms24
reviewed
Jan 24, 2023
|
|
||
| - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott | ||
|
|
||
| ## 7.32.2 |
Member
There was a problem hiding this comment.
I'd vote this should be a minor as removing default sample rates in Replay is quite an important change.
Suggested change
| ## 7.32.2 | |
| ## 7.33.0 |
Contributor
Author
There was a problem hiding this comment.
Sounds good. I also added a note explaining the change.
Lms24
approved these changes
Jan 24, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for adding the sentence about Replay ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.