Exclude divs and spans from stacktrace

[armenzg]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/react

SDK Version

7.51.10

Framework Version

No response

Link to Sentry event

https://sentry.sentry.io/issues/4146750272/?project=11276

SDK Setup

n/a

Steps to Reproduce

• Load the URL provided
• Scroll down to "React ErrorBoundary Error"

Expected Result

div and span should not be included in the stacktrace frames.

Actual Result

If you look under raw_stacktrace you will see the following:

{
"filename": "div",
"abs_path": "div",
"in_app": true
},
{
"filename": "span",
"abs_path": "span",
"in_app": true
}

[lforst]

Thanks for reporting. What is the desired behaviour in your opinion?

[armenzg]

Hi @lforst, excluding any HTML elements.

[AbhiPrasad]

These frames come from the stacktrace the React ErrorBoundary generates.

Due to the limitations of errorboundaries, react cannot give line/col numbers for html elements, but users might still find it useful to understand how components are nested.

Maybe we can improve this in the UI somehow? For now I would not consider this a bug.

[armenzg]

I've added a screenshot in the description for posterity.

The problem of being included in the stacktrace is that they will be considered as part of the fingerprinting of the group. Perhaps that is fine but I want to call it out in case it matters for any of our discussions.

It may make sense to only to focus on the UI as it brings no value at the moment.

@AbhiPrasad Would just hiding html elements from the UI be good enough? Developers could still see them if they wish to via the raw stacktrace.

[armenzg]

Should we file a separate issue for this?

[AbhiPrasad]

Would just hiding html elements from the UI be good enough? Developers could still see them if they wish to via the raw stacktrace

Yup I think that's a good idea. We should also try cleaning up the invalid location in sourcemap error. React ErrorBoundary errors should have ErrorBoundary in the title - perhaps we can supress the warning if we see this?

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀