Skip to content

fix(nextjs): Fix package.json exports #8895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lforst merged 1 commit into from
Aug 29, 2023
Merged

fix(nextjs): Fix package.json exports #8895

lforst merged 1 commit into from
Aug 29, 2023

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Aug 29, 2023 •
edited
Loading

Fixes #8884

Hot fix for bug caused by #8875

AbhiPrasad
AbhiPrasad approved these changes Aug 29, 2023
View reviewed changes
packages/nextjs/src/config/loaders/wrappingLoader.ts
templateCode = templateCode.replace(
/__SENTRY_NEXTJS_REQUEST_ASYNC_STORAGE_SHIM__/g,
'@sentry/nextjs/requestAsyncStorageShim',
'@sentry/nextjs/build/esm/config/templates/requestAsyncStorageShim.js',
Copy link
Member

@AbhiPrasad AbhiPrasad Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Lms24
Lms24 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's unblock folks

@Lms24 Lms24 changed the title fix(nextjs): Fix package.json exports feat(nextjs): Fix package.json exports Aug 29, 2023
@Lms24 Lms24 changed the title feat(nextjs): Fix package.json exports fix(nextjs): Fix package.json exports Aug 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.23 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.22 KB (+0.06% 🔺)
@sentry/browser - Webpack (gzipped) 21.86 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.76 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.18 KB (-0.11% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.19 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.02 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.85 KB (-0.05% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.84 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.07 KB (-0.11% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.25 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 21.89 KB (+0.06% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.09 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.75 KB (+0.04% 🔺)

@lforst lforst merged commit fe2c801 into develop Aug 29, 2023
@lforst lforst deleted the lforst-fix-pkgjson-exports branch August 29, 2023 13:35
JoeKarow added a commit to weareinreach/InReach that referenced this pull request Aug 29, 2023
@JoeKarow
roll @sentry/* back to 7.64.0 until getsentry/sentry-javascript#8895 …
ef0354e 
…released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build error in Next Config @sentry/nextjs

4 participants

@lforst @Lms24 @AbhiPrasad