Skip to content

Conversation

@kamilogorek
Copy link
Contributor

Closes #1013

@kamilogorek kamilogorek requested a review from a team October 11, 2017 11:32
Copy link
Contributor

@MaxBittker MaxBittker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, except maybe this implies that regexp always are exact matches? obviously your example shows ^$ but it could be misleading if someone misses that

@benvinegar
Copy link
Contributor

benvinegar commented Oct 12, 2017

good point, except maybe this implies that regexp always are exact matches?

We could elaborate, but I think the example is sufficiently clear. Not a big deal; this is an objective improvement.

@kamilogorek
Copy link
Contributor Author

I think that if someone is brave enough to use RegExp, then they know what ^$ means :D

@kamilogorek kamilogorek merged commit 785a95e into master Oct 12, 2017
@kamilogorek kamilogorek deleted the ignore-errors-docs branch October 12, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants