Skip to content

Conversation

@logaretm
Copy link
Collaborator

@logaretm logaretm commented Oct 9, 2025

This pull request introduces automatic instrumentation for database queries in Nuxt applications in server side handlers using Sentry.

Implementation Details

  • Instruments database .sql, .prepare and .exec calls.
  • Adds breadcrumbs and spans following cloudflare's D1 implementation.

This relies on the work done in #17858 and #17886

@linear
Copy link

linear bot commented Oct 9, 2025

@logaretm logaretm force-pushed the awad/js-1036-nuxtnitro-instrument-database-sqlite branch 4 times, most recently from 7f29d2e to 55ca147 Compare October 15, 2025 10:17
@logaretm logaretm changed the base branch from develop to awad/js-1023-nuxtnitro-instrument-cache October 15, 2025 10:17
@logaretm logaretm force-pushed the awad/js-1023-nuxtnitro-instrument-cache branch from c844c9e to 17482e2 Compare October 15, 2025 10:31
@logaretm logaretm force-pushed the awad/js-1036-nuxtnitro-instrument-database-sqlite branch from 55ca147 to 76ad329 Compare October 15, 2025 10:32
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.64 kB - -
@sentry/browser - with treeshaking flags 23.14 kB - -
@sentry/browser (incl. Tracing) 40.99 kB - -
@sentry/browser (incl. Tracing, Replay) 79.29 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.98 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 84 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 96.16 kB - -
@sentry/browser (incl. Feedback) 41.33 kB - -
@sentry/browser (incl. sendFeedback) 29.3 kB - -
@sentry/browser (incl. FeedbackAsync) 34.26 kB - -
@sentry/react 26.35 kB - -
@sentry/react (incl. Tracing) 42.99 kB - -
@sentry/vue 29.13 kB - -
@sentry/vue (incl. Tracing) 42.79 kB - -
@sentry/svelte 24.66 kB - -
CDN Bundle 26.94 kB - -
CDN Bundle (incl. Tracing) 41.65 kB - -
CDN Bundle (incl. Tracing, Replay) 77.89 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 83.35 kB - -
CDN Bundle - uncompressed 78.95 kB - -
CDN Bundle (incl. Tracing) - uncompressed 123.53 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 238.54 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 251.31 kB - -
@sentry/nextjs (client) 45.06 kB - -
@sentry/sveltekit (client) 41.42 kB - -
@sentry/node-core 50.78 kB - -
@sentry/node 154.4 kB - -
@sentry/node - without tracing 92.65 kB - -
@sentry/aws-serverless 106.35 kB -0.01% -1 B 🔽

View base workflow run

@logaretm logaretm force-pushed the awad/js-1023-nuxtnitro-instrument-cache branch from 17482e2 to 65277c7 Compare October 15, 2025 10:43
@logaretm logaretm force-pushed the awad/js-1036-nuxtnitro-instrument-database-sqlite branch from 68758a1 to 9599b1d Compare October 15, 2025 10:45
@logaretm logaretm marked this pull request as ready for review October 15, 2025 12:26
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@logaretm logaretm force-pushed the awad/js-1023-nuxtnitro-instrument-cache branch from 65277c7 to 604de80 Compare October 15, 2025 20:55
@logaretm logaretm force-pushed the awad/js-1036-nuxtnitro-instrument-database-sqlite branch from 7c1e749 to f9dcb00 Compare October 15, 2025 20:55
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. Just have some small comments

@logaretm logaretm force-pushed the awad/js-1023-nuxtnitro-instrument-cache branch from 604de80 to f1dd874 Compare October 16, 2025 21:18
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Base automatically changed from awad/js-1023-nuxtnitro-instrument-cache to develop October 17, 2025 11:26
@logaretm logaretm force-pushed the awad/js-1036-nuxtnitro-instrument-database-sqlite branch from e7ef962 to ce6f4bd Compare October 17, 2025 11:28
@logaretm logaretm merged commit f94b203 into develop Oct 17, 2025
65 of 69 checks passed
@logaretm logaretm deleted the awad/js-1036-nuxtnitro-instrument-database-sqlite branch October 17, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants