Skip to content

fix(tracemetrics): Send boolean for internal replay attribute #17908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2025
Merged

fix(tracemetrics): Send boolean for internal replay attribute #17908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fdd2d39
send boolean
chargome Oct 10, 2025
908f23a
fix test
chargome Oct 13, 2025
d4f0ed3
Merge branch 'develop' into cg-metrics-replay-id
chargome Oct 13, 2025
840dd2d
Merge branch 'develop' into cg-metrics-replay-id
chargome Oct 14, 2025
e61562b
Merge branch 'develop' into cg-metrics-replay-id
chargome Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/metrics/internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export function _INTERNAL_captureMetric(beforeMetric: Metric, options?: Internal

if (replayId && replay?.getRecordingMode() === 'buffer') {
// We send this so we can identify cases where the replayId is attached but the replay itself might not have been sent to Sentry
setMetricAttribute(processedMetricAttributes, 'sentry._internal.replay_is_buffering', replayId);
setMetricAttribute(processedMetricAttributes, 'sentry._internal.replay_is_buffering', true);
}

const metric: Metric = {
Expand Down
12 changes: 6 additions & 6 deletions packages/core/test/lib/metrics/internal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,8 @@ describe('_INTERNAL_captureMetric', () => {
type: 'string',
},
'sentry._internal.replay_is_buffering': {
value: 'buffer-replay-id',
type: 'string',
value: true,
type: 'boolean',
},
});
});
Expand Down Expand Up @@ -577,8 +577,8 @@ describe('_INTERNAL_captureMetric', () => {
type: 'string',
},
'sentry._internal.replay_is_buffering': {
value: 'buffer-replay-id',
type: 'string',
value: true,
type: 'boolean',
},
});
});
Expand Down Expand Up @@ -736,8 +736,8 @@ describe('_INTERNAL_captureMetric', () => {
type: 'string',
},
'sentry._internal.replay_is_buffering': {
value: 'buffer-replay-id',
type: 'string',
value: true,
type: 'boolean',
},
});
});
Expand Down
Loading