feat(node): Capture pino logger name
#17930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| 'pino.logger.level': levelNumber, | ||
| }; | ||
|
|
||
| const parsedResult = JSON.parse(result) as { name?: string }; |
There was a problem hiding this comment.
Bug: Pino JSON Parsing Fails Without Error Handling
The JSON.parse(result) call lacks error handling. If the result string from Pino's asJson function is malformed, it throws an uncaught exception. This can crash the integration and prevent log capture.
There was a problem hiding this comment.
If the string doesn't parse as json we've got more fundamental issues!
AbhiPrasad
approved these changes
Oct 14, 2025
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
andreiborza
pushed a commit
to thedanchez/sentry-javascript
that referenced
this pull request
Oct 15, 2025
Pino loggers can be named but we didn't capture this information:
```ts
import pino from 'pino';
const logger = pino({ name: 'my-component' });
```
This PR changes the hook from `start` to `end` which means we can parse
the output JSON and fetch the name if one was supplied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pino loggers can be named but we didn't capture this information:
This PR changes the hook from
starttoendwhich means we can parse the output JSON and fetch the name if one was supplied.