Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Nov 13, 2025

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Fixes a test failure where process.env.SENTRY_SPOTLIGHT was not cleaned up after a test, causing environment variable pollution for subsequent tests.

The failing test expected spotlight: true to resolve to true, but due to the lingering environment variable, it received the URL from SENTRY_SPOTLIGHT instead.

This PR adds an afterEach hook to the spotlight configuration describe block to ensure process.env.SENTRY_SPOTLIGHT is deleted after each test, preventing cross-test contamination.


Open in Cursor Open in Web

Co-authored-by: burak.kaya <burak.kaya@sentry.io>
@cursor
Copy link

cursor bot commented Nov 13, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.6 kB added added
@sentry/browser - with treeshaking flags 23.09 kB added added
@sentry/browser (incl. Tracing) 41.26 kB added added
@sentry/browser (incl. Tracing, Profiling) 45.53 kB added added
@sentry/browser (incl. Tracing, Replay) 79.73 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.4 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 84.42 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 96.58 kB added added
@sentry/browser (incl. Feedback) 41.27 kB added added
@sentry/browser (incl. sendFeedback) 29.27 kB added added
@sentry/browser (incl. FeedbackAsync) 34.2 kB added added
@sentry/react 26.29 kB added added
@sentry/react (incl. Tracing) 43.22 kB added added
@sentry/vue 29.09 kB added added
@sentry/vue (incl. Tracing) 43.03 kB added added
@sentry/svelte 24.61 kB added added
CDN Bundle 26.9 kB added added
CDN Bundle (incl. Tracing) 41.81 kB added added
CDN Bundle (incl. Tracing, Replay) 78.33 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 83.81 kB added added
CDN Bundle - uncompressed 78.84 kB added added
CDN Bundle (incl. Tracing) - uncompressed 124 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 240.03 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 252.79 kB added added
@sentry/nextjs (client) 45.34 kB added added
@sentry/sveltekit (client) 41.64 kB added added
@sentry/node-core 50.86 kB added added
@sentry/node 157.99 kB added added
@sentry/node - without tracing 92.73 kB added added
@sentry/aws-serverless 106.5 kB added added

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,198 - - added
GET With Sentry 1,371 15% - added
GET With Sentry (error only) 6,075 66% - added
POST Baseline 1,202 - - added
POST With Sentry 520 43% - added
POST With Sentry (error only) 1,072 89% - added
MYSQL Baseline 3,296 - - added
MYSQL With Sentry 477 14% - added
MYSQL With Sentry (error only) 2,679 81% - added

@BYK BYK marked this pull request as ready for review November 13, 2025 13:48
@BYK BYK merged commit e2bff22 into feat/node-spotlight-precedence-fix Nov 13, 2025
136 checks passed
@BYK BYK deleted the cursor/fix-spotlight-config-test-assertion-847f branch November 13, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants