Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Nov 14, 2025

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Fixes a test failure where getSpotlightConfig was returning empty or whitespace-only strings for SENTRY_SPOTLIGHT environment variables, instead of undefined. This change explicitly filters out such values, aligning the function's behavior with test expectations and preventing invalid Spotlight configurations.


Open in Cursor Open in Web

Co-authored-by: burak.kaya <burak.kaya@sentry.io>
@cursor
Copy link

cursor bot commented Nov 14, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.6 kB added added
@sentry/browser - with treeshaking flags 23.09 kB added added
@sentry/browser (incl. Tracing) 41.26 kB added added
@sentry/browser (incl. Tracing, Profiling) 45.53 kB added added
@sentry/browser (incl. Tracing, Replay) 79.73 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.4 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 84.42 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 96.58 kB added added
@sentry/browser (incl. Feedback) 41.27 kB added added
@sentry/browser (incl. sendFeedback) 29.27 kB added added
@sentry/browser (incl. FeedbackAsync) 34.2 kB added added
@sentry/react 26.29 kB added added
@sentry/react (incl. Tracing) 43.22 kB added added
@sentry/vue 29.09 kB added added
@sentry/vue (incl. Tracing) 43.03 kB added added
@sentry/svelte 24.61 kB added added
CDN Bundle 26.95 kB added added
CDN Bundle (incl. Tracing) 41.85 kB added added
CDN Bundle (incl. Tracing, Replay) 78.38 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 83.85 kB added added
CDN Bundle - uncompressed 78.92 kB added added
CDN Bundle (incl. Tracing) - uncompressed 124.08 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 240.11 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 252.87 kB added added
@sentry/nextjs (client) 45.34 kB added added
@sentry/sveltekit (client) 41.64 kB added added
@sentry/node-core 50.87 kB added added
@sentry/node 158.06 kB added added
@sentry/node - without tracing 92.74 kB added added
@sentry/aws-serverless 106.5 kB added added

cursoragent and others added 2 commits November 14, 2025 16:52
Co-authored-by: burak.kaya <burak.kaya@sentry.io>
Co-authored-by: burak.kaya <burak.kaya@sentry.io>
@BYK BYK marked this pull request as ready for review November 14, 2025 16:59
@BYK BYK requested a review from a team as a code owner November 14, 2025 16:59
@BYK BYK merged commit 0ac2828 into feat/spotlight-environment-variable-support Nov 14, 2025
6 checks passed
@BYK BYK deleted the cursor/fix-test-failure-in-ci-4a42 branch November 14, 2025 16:59
@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,135 - - added
GET With Sentry 1,399 15% - added
GET With Sentry (error only) 6,215 68% - added
POST Baseline 1,231 - - added
POST With Sentry 528 43% - added
POST With Sentry (error only) 1,090 89% - added
MYSQL Baseline 3,399 - - added
MYSQL With Sentry 527 16% - added
MYSQL With Sentry (error only) 2,770 81% - added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants