Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 18, 2025

Both of these units are supported by Relay, see https://getsentry.github.io/relay/relay_metrics/enum.InformationUnit.html.

(somewhat related to #18165. Happy to close if there's a reason why we didn't add them initially)

@Lms24 Lms24 requested review from AbhiPrasad and chargome November 18, 2025 11:45
@Lms24 Lms24 changed the title feat(core): Add gibibyte and pebibyte to InformationUnit feat(core): Add gibibyte and pebibyte to InformationUnit type Nov 18, 2025
@Lms24 Lms24 self-assigned this Nov 18, 2025
@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 11,508 - 8,956 +28%
GET With Sentry 1,704 15% 1,397 +22%
GET With Sentry (error only) 7,799 68% 6,044 +29%
POST Baseline 1,199 - 1,213 -1%
POST With Sentry 565 47% 532 +6%
POST With Sentry (error only) 1,065 89% 1,076 -1%
MYSQL Baseline 4,053 - 3,383 +20%
MYSQL With Sentry 612 15% 546 +12%
MYSQL With Sentry (error only) 3,389 84% 2,796 +21%

View base workflow run

@Lms24 Lms24 merged commit 49badb0 into develop Nov 19, 2025
743 of 759 checks passed
@Lms24 Lms24 deleted the lms/feat-core-metricUnits branch November 19, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants