Skip to content

Conversation

@nicohrubec
Copy link
Member

@nicohrubec nicohrubec commented Dec 1, 2025

This sets up a basic E2E test for the Tanstack Start React SDK.

For now I have added the following three tests:

  • An error thrown directly on the client is automatically captured.
  • An error thrown from a server side function is automatically captured. I am not sure why this works atm, but probably this is somehow propagated to the frontend.
  • An error thrown from a server route is only captured if we manually instrument it with Sentry.captureException.

Closes #18265

@nicohrubec nicohrubec self-assigned this Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,113 - 9,036 +1%
GET With Sentry 1,716 19% 1,738 -1%
GET With Sentry (error only) 6,135 67% 6,057 +1%
POST Baseline 1,192 - 1,193 -0%
POST With Sentry 583 49% 593 -2%
POST With Sentry (error only) 1,048 88% 1,061 -1%
MYSQL Baseline 3,320 - 3,354 -1%
MYSQL With Sentry 451 14% 456 -1%
MYSQL With Sentry (error only) 2,676 81% 2,727 -2%

View base workflow run

@nicohrubec nicohrubec marked this pull request as ready for review December 3, 2025 07:40
@nicohrubec nicohrubec linked an issue Dec 3, 2025 that may be closed by this pull request
2 tasks
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicohrubec nicohrubec merged commit 2f134c2 into develop Dec 3, 2025
35 checks passed
@nicohrubec nicohrubec deleted the nh/add-tanstackstart-react-e2e branch December 3, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Tanstack Start E2E test application

3 participants