Fix absent method now on window.Performance
#2658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an issue in our self-hosted sentry `Object [object Performance] has no method 'now'` It shows `Sentry.addBreadcrumb` as the source of the error. It seems that some browsers can have performance without `now` method. 50% of all events from Chrome 22.0.1229 - I know that it's pretty old - but the fix seems trivial
kamilogorek
approved these changes
Jun 9, 2020
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue in our self-hosted sentry
Object [object Performance] has no method 'now'It shows
Sentry.addBreadcrumbas the source of the error.It seems that some browsers can have global performance object without
nowmethod.50% of all events from Chrome 22.0.1229 - I know that it's pretty old - but the fix seems trivial