Skip to content

test: Add a test suite with 100% [brag] code coverage to AWSLambda handler #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2020
Merged

test: Add a test suite with 100% [brag] code coverage to AWSLambda handler #2891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26ab27a
test: Add a test suite with 100% [brag] code coverage to AWSLambda ha…
kamilogorek Sep 10, 2020
49bb5c1
Update rethrow test
kamilogorek Sep 15, 2020
05514cc
linterz plz
kamilogorek Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/serverless/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@ module.exports = {
project: './tsconfig.json',
},
},
{
files: ['test/**'],
rules: {
'no-empty': 'off',
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
},
},
],
rules: {
'@typescript-eslint/no-var-requires': 'off',
Expand Down
27 changes: 24 additions & 3 deletions packages/serverless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,14 @@
"@sentry/node": "5.23.0",
"@sentry/types": "5.23.0",
"@sentry/utils": "5.23.0",
"@types/aws-lambda": "^8.10.62",
"@types/node": "^14.6.4",
"tslib": "^1.9.3"
},
"devDependencies": {
"@sentry-internal/eslint-config-sdk": "5.23.0",
"@types/aws-lambda": "^8.10.62",
"@types/node": "^14.6.4",
"eslint": "7.6.0",
"jest": "^24.7.1",
"npm-run-all": "^4.1.2",
"prettier": "1.19.0",
"rimraf": "^2.6.3",
Expand All @@ -51,5 +52,25 @@
"test:watch": "jest --watch --passWithNoTests",
"pack": "npm pack"
},
"sideEffects": false
"sideEffects": false,
"jest": {
"collectCoverage": true,
"transform": {
"^.+\\.ts$": "ts-jest"
},
"moduleFileExtensions": [
"js",
"ts"
],
"testEnvironment": "node",
"testMatch": [
"**/*.test.ts"
],
"globals": {
"ts-jest": {
"tsConfig": "./tsconfig.json",
"diagnostics": false
}
}
}
}
5 changes: 1 addition & 4 deletions packages/serverless/src/awslambda.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,7 @@ export const wrapHandler = <TEvent = any, TResult = any>(
if (args[0] === null || args[0] === undefined) {
resolve(callback(...args));
} else {
captureExceptionAsync(args[0], context, options).then(
() => reject(callback(...args)),
() => reject(callback(...args)),
);
captureExceptionAsync(args[0], context, options).finally(() => reject(callback(...args)));
}
};
};
Expand Down
Empty file removed packages/serverless/test/.gitkeep
View file
Open in desktop
Empty file.
26 changes: 26 additions & 0 deletions packages/serverless/test/__mocks__/@sentry/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
export const SDK_VERSION = '6.6.6';
export const Severity = {
Warning: 'warning',
};
export const fakeScope = {
addEventProcessor: jest.fn(),
setTransactionName: jest.fn(),
setTag: jest.fn(),
setContext: jest.fn(),
};
export const captureException = jest.fn();
export const captureMessage = jest.fn();
export const withScope = jest.fn(cb => cb(fakeScope));
export const flush = jest.fn(() => Promise.resolve());

export const resetMocks = (): void => {
fakeScope.addEventProcessor.mockClear();
fakeScope.setTransactionName.mockClear();
fakeScope.setTag.mockClear();
fakeScope.setContext.mockClear();

captureException.mockClear();
captureMessage.mockClear();
withScope.mockClear();
flush.mockClear();
};
Loading