chore(dev): Use Node 14 for development work #3588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
kamilogorek
approved these changes
May 24, 2021
Contributor
kamilogorek
left a comment
kamilogorek
left a comment
There was a problem hiding this comment.
I don't think there's a risk of doing that, as we run all our builds and tests on multiple node versions anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps us from Node 10 to Node 14, primarily to get around issues in the VSCode debugger, which won't run under Node 10 anymore.
The one danger in doing so would be that we might use a newer feature of Node which doesn't exist in older versions we're still supporting and doesn't get transpiled down, and not realize we're doing so until it breaks some customer's app. Fortunately, you can tell TS what Node version you're targeting through the use of particular combinations of
tsconfigsettings. The oldest version for which they have a spec is Node 10, but that's what we've been using all along anyway. Fortunately, according to that list, all of our current settings already fulfill the requirements.