Remove TraceKit-specific options from docs #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
benvinegar
added a commit
that referenced
this pull request
Jan 12, 2016
Remove TraceKit-specific options from docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just docs for now, but we are going to deprecate these features soon.
Why?
fetchContext– now that you can upload source code directly to Sentry, this is unnecessary and bad practice. This feature used synchronous XHR to fetch source code, locking the UI thread / freezing browser until it completed.linesOfContext– seefetchContextcollectWindowErrors– now that we automatically wrap browser built-ins likesetTimeout, removing the window.onerror handler isn't going to stop Raven from catching all your errors. If you just want to callRaven.captureException/captureMessage, don't callRaven.install()and it should work fine.