Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Oct 9, 2024

regex in craft.yml doesn't match releases with double digits e.g 0.10.0 which would replace the aar name

#skip-changelog

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (a8cebc1) to head (f9f0051).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   76.48%   76.48%           
=======================================
  Files          39       39           
  Lines         608      608           
  Branches       86       86           
=======================================
  Hits          465      465           
  Misses         97       97           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review October 11, 2024 09:30
@buenaflor buenaflor requested a review from romtsn as a code owner October 11, 2024 09:30
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice touch with the validate task 👍 also I feel you :D getsentry/sentry-java#2433

@buenaflor
Copy link
Contributor Author

also I feel you :D getsentry/sentry-java#2433

ahh lol 🤣

@buenaflor buenaflor enabled auto-merge (squash) October 15, 2024 14:57
@buenaflor buenaflor merged commit bcd7a1b into main Oct 15, 2024
11 checks passed
@buenaflor buenaflor deleted the fix/publish-2 branch October 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants