Metrics are not flushed when used in jobs

[pataar]

How do you use Sentry?

Self-hosted / on-premises

SDK version

4.5.1

Steps to reproduce

1. Use metrics in async jobs
2. See that they're not being pushed to Sentry

Expected result

I was expecting results when using metrics in an Event listener that's fired in a job. Job is done async using the database driver.

Actual result

The metric doesn't get posted to Sentry. Might be because of a missing flush. Metrics done using normal requests are handled correctly.

[stayallive]

Interesting that this is your second queue related bug. Seems like your project might do something non-standard in its queue operations.

What Laravel version are you using and can you maybe show me a minimal reproducible example so I can try to replicate?

We are flushing metrics after job execution (and I know this to be working in production applications) but we might be missing something or missing something for a specific Laravel version.

[pataar]

Interesting that this is your second queue related bug. Seems like your project might do something non-standard in its queue operations.

What Laravel version are you using and can you maybe show me a minimal reproducible example so I can try to replicate?

We are flushing metrics after job execution (and I know this to be working in production applications) but we might be missing something or missing something for a specific Laravel version.

Using Laravel version v10.48.12. PHP version 8.3. We're executing jobs using 6 replicated pods in Kubernetes that run the php /var/www/artisan queue:work database --sleep=3 --tries=3 command.

One thing that might be relevant is that we're executing metrics in EventListeners as follows:

class AppUserPushNotificationSentListener {
	/**
	 * Create the event listener.
	 */
	public function __construct() {}

	/**
	 * Handle the event.
	 */
	public function handle(AppUserPushNotificationSent $event): void {
		$currentInstance = CurrentInstance::get();

		metrics()->increment(
			key: 'push_notification_sent',
			value: $event->nativeDevicesCount,
			tags: [
				'instance_url_prefix' => $currentInstance?->getUrlPrefix(),
				'instance_id' => $currentInstance?->getId(),
				'treatment_id' => $event->notification->treatment_id,
				'is_background' => $event->notification->is_background,
			],
		);
	}
}

[pataar]

@stayallive does the sampling rate affect metrics?

[pataar]

Think I've found the issue. Tags must use string values.

[stayallive]

Ah yes, we try to communicate that with a docblock since there is not a perfect way to ensure that is the case in PHP otherwise: https://github.com/getsentry/sentry-php/blob/1ea8e3d8ec549de508b3644cd09dbc251bd53b0f/src/Metrics/Metrics.php#L43

Those warnings seems like a great way to surface this issue without us adding type checks that might crash your application (by throwing or emitting errors) if you give us wrong tags.

I'll close this one for now, since I think this is not an issue with the SDK and metrics are flushed as expected in jobs.

[pataar]

Seems to work now 😁